git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 1/1] repo: add filtering options to "repo structure"

From
MCMark C. Chu-Carroll <markchucarroll@fastmail.com>
Date
Oct 15, 2026, 14:44 UTC
Message-ID
<DM5HQ9U1JWFE.28OMPLQUD2E7P@fastmail.com>
In-Reply-To
<as9yXVSdEh526Qi9@pks.im>
On Wed Oct 14, 2026 at 8:15 AM EDT, Patrick Steinhardt wrote:
Show 18 quoted lines
> On Tue, Oct 13, 2026 at 01:28:51PM -0400, Mark C. Chu-Carroll wrote:
>> index 84e012f83f..f45dea06d5 100644
>> --- a/builtin/repo.c
>> +++ b/builtin/repo.c
>> @@ -947,16 +953,20 @@ static int cmd_repo_structure(int argc, const char **argv, const char *prefix,
>>  		OPT_END()
>  	};
>> ...
>> +		if (argc > 1)
>> +			usage(_("too many arguments"));
>
> Nit: it's not "too many arguments", it's unrecognized arguments here as
> the number of arguments can theoretically be unlimited. Copying patterns
> from other builtins:
>
> 	argc = setup_revisions(argc, argv, &revs, NULL);
> 	if (argc > 1)
> 		return error(_("unrecognized argument: %s"), argv[1]);

Right. I was just keeping the original error message; but since we're now taking a potentially unbounded list of rev args, that message no longer makes sense.

Show 17 quoted lines
>> diff --git a/t/t1901-repo-structure.sh b/t/t1901-repo-structure.sh
>> index 02cc2b594a..1d25ee14e5 100755
>> --- a/t/t1901-repo-structure.sh
>> +++ b/t/t1901-repo-structure.sh
>> @@ -140,10 +140,208 @@ test_expect_success SHA1 'repository with references and objects' '
> [snip]
> ...
>> +		test_must_be_empty err
>>  	)
>>  '
>>  
>> +
>>  test_expect_success SHA1 'lines and nul format' '
>>  	test_when_finished "rm -rf repo" &&
>>  	git init repo &&
>
> There's a trailing newline being added here.

Sorry. I've got some vision issues, and as a result, it's difficult for me to see whitespace - one space or one newline versus two is pretty much invisible for me.

>> @@ -186,13 +384,13 @@ test_expect_success SHA1 'lines and nul format' '
>
> I'd drop these while-at-it changes. If you want to include them they
> should be part of a preparatory commit.

Will drop. My reflex is to change all instances of something after a comment like this.

  -Mark
-- 
Mark Craig Chu-Carroll (@MarkChuCarroll at gitlab)
*** Software Tools/Math Geek - Software Engineer at Gitlab
*** Work Email: mcarroll@gitlab.com / markchucarroll@fastmail.com
*** Personal Blog: http://goodmath.org/blog / Personal email: markcc@gmail.com
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 22 of 35 in “repo: add filtering options to "repo structure"”
  1. 0/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Sep 24, 2026
  2. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Sep 24, 2026
  3. Patrick SteinhardtSep 30, 2026
  4. Mark C. Chu-CarrollOct 5, 2026
  5. 0/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 5, 2026
  6. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 5, 2026
  7. Patrick SteinhardtOct 6, 2026
  8. Kaartic SivaraamOct 8, 2026
  9. Mark C. Chu-CarrollOct 9, 2026
  10. 0/1 repo: add revision filtering options to "repo structure"Mark C. Chu-Carroll, Oct 9, 2026
  11. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 9, 2026
  12. Junio C HamanoOct 9, 2026
  13. Mark C. Chu-CarrollOct 10, 2026
  14. 0/1 repo: add revision filtering options to "repo structure"Mark C. Chu-Carroll, Oct 10, 2026
  15. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 10, 2026
  16. Patrick SteinhardtOct 13, 2026
  17. Mark C. Chu-CarrollOct 13, 2026
  18. Patrick SteinhardtOct 13, 2026
  19. 0/1 repo: add revision filtering options to "repo structure"Mark C. Chu-Carroll, Oct 13, 2026
  20. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 13, 2026
  21. Patrick SteinhardtOct 14, 2026
  22. Mark C. Chu-CarrollOct 15, 2026
  23. Patrick SteinhardtOct 15, 2026
  24. 0/1 repo: add revision filtering options to "repo structure"Mark C. Chu-Carroll, Oct 15, 2026
  25. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 15, 2026
  26. Kristoffer HaugsbakkOct 15, 2026
  27. Mark C. Chu-CarrollOct 15, 2026
  28. 0/1 repo: add revision filtering options to "repo structure"Mark C. Chu-Carroll, Oct 15, 2026
  29. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 15, 2026
  30. Junio C HamanoOct 17, 2026
  31. 0/1 repo: add revision filtering options to "repo structure"Mark C. Chu-Carroll, Oct 15, 2026
  32. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 15, 2026
  33. Patrick SteinhardtOct 16, 2026
  34. 0/1 repo: add revision filtering options to "repo structure"Mark C. Chu-Carroll, Oct 16, 2026
  35. 1/1 repo: add filtering options to "repo structure"Mark C. Chu-Carroll, Oct 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.