Re: [PATCH v2 1/1] repo: add filtering options to "repo structure"
On Thu Oct 8, 2026 at 11:46 AM EDT, Kaartic Sivaraam wrote:
Show 21 quoted lines
> On 10/6/26 11:21, Patrick Steinhardt wrote:
>> On Mon, Oct 05, 2026 at 01:40:44PM -0400, Mark C. Chu-Carroll wrote:
>>> Implement filtering for repo structure, imitating the mechanism
>>> used in "git log".
>>
>> The message should give an explanation of what this change does, and
>> what the motivation behind it is.
>>
>
> Indeed. The cover letter provides more context about the change. I think
> it makes sense to include a significant portion of the cover letter in
> the commit message. We could even likely drop the cover letter
> altogether if it feels to add no value.
>
> That said,
>
> > repo: add filtering options to "repo structure"
>
> I think the following may be a better commit title:
>
> repo: add revision filtering support to "repo structure"
You're right - that's much better.
-Mark
--
Mark Craig Chu-Carroll (@MarkChuCarroll at gitlab)
*** Software Tools/Math Geek - Software Engineer at Gitlab
*** Work Email: mcarroll@gitlab.com / markchucarroll@fastmail.com
*** Personal Blog: http://goodmath.org/blog / Personal email: markcc@gmail.com