git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix git-instaweb breakage on MacOS X due to the limited sed functionality

From
Wincent Colaiuta <win@wincent.com>
Date
Dec 19, 2007, 11:55 UTC
Message-ID
<DE63D291-1B73-41FB-AF56-9B671A6A66E4@wincent.com>
In-Reply-To
<20071219114823.GA28273@hashpling.org>
El 19/12/2007, a las 12:48, Charles Bailey escribió:
Show 10 quoted lines
> On Wed, Dec 19, 2007 at 12:43:12PM +0100, Wincent Colaiuta wrote:
>> El 19/12/2007, a las 12:36, Charles Bailey escribió:
>>
>>> I agree completely, but all the generated scripts output hard coded
>>> paths so it would seem inconsistent not to qualify the path in this
>>> case too.
>>
>> It's not hard-coded, it's dynamic. Witness:
>
> It's *output* hardcoded, it's dynamic during script generation.

Ah, ok. Seems like we were working with different definitions of "hard- coded". When I said "hard-coded" I meant "determined by you and not overrideable by the user doing the build without hand-editing the source file".

> A raw 'perl' in a shell script is dynamic during script run.

Sure, and seeing as you're only doing a simple find/replace any version of perl installed on the path is probably fine.

But if you are going to provide an absolute path then you should at least make it user-configurable like all the other perl paths.

Cheers, Wincent

Previous: Charles Bailey
Message 9 of 9 in “Fix git-instaweb breakage on MacOS X due to the limited sed functionality”
  1. Fix git-instaweb breakage on MacOS X due to the limited sed functionalityCharles Bailey, Dec 19, 2007
  2. Wincent ColaiutaDec 19, 2007
  3. Charles BaileyDec 19, 2007
  4. Wincent ColaiutaDec 19, 2007
  5. Charles BaileyDec 19, 2007
  6. Charles BaileyDec 19, 2007
  7. Charles BaileyDec 19, 2007
  8. Fix git-instaweb breakage on MacOS X due to the limited sed functionalityCharles Bailey, Dec 19, 2007
  9. Wincent ColaiutaDec 19, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.