From: Wincent Colaiuta Date: Wed, 19 Dec 2007 11:55:37 GMT Subject: Re: [PATCH] Fix git-instaweb breakage on MacOS X due to the limited sed functionality Message-ID: In-Reply-To: <20071219114823.GA28273@hashpling.org> El 19/12/2007, a las 12:48, Charles Bailey escribió: > On Wed, Dec 19, 2007 at 12:43:12PM +0100, Wincent Colaiuta wrote: >> El 19/12/2007, a las 12:36, Charles Bailey escribió: >> >>> I agree completely, but all the generated scripts output hard coded >>> paths so it would seem inconsistent not to qualify the path in this >>> case too. >> >> It's not hard-coded, it's dynamic. Witness: > > It's *output* hardcoded, it's dynamic during script generation. Ah, ok. Seems like we were working with different definitions of "hard- coded". When I said "hard-coded" I meant "determined by you and not overrideable by the user doing the build without hand-editing the source file". > A raw 'perl' in a shell script is dynamic during script run. Sure, and seeing as you're only doing a simple find/replace any version of perl installed on the path is probably fine. But if you are going to provide an absolute path then you should at least make it user-configurable like all the other perl paths. Cheers, Wincent