Re: [PATCH] Fix git-instaweb breakage on MacOS X due to the limited sed functionality

From: Wincent Colaiuta <win@wincent.com>
Date: Dec 19, 2007, 11:28 UTC
Message-ID: <23306E3C-24F1-4626-A956-02531644B786@wincent.com>
In-Reply-To: <20071219105752.GA23932@hashpling.org>

El 19/12/2007, a las 11:57, Charles Bailey escribió:

> -	sed "$script" "$1.tmp"  > "$1"
> +	# The generated scripts assume that perl is /usr/bin/perl
> +	# so the assumption here should be no more harmful
> +	/usr/bin/perl -p -e "$script" "$1.tmp"  > "$1"

I think it's a bad idea to hard-code the perl path there; the generated scripts only assume /usr/bin/perl if the user hasn't overridden it at build time:

	PERL_PATH=/foo/perl make ...

Using just this should work fine anyway:

	perl -p -e ...

Cheers, Wincent