Re: [PATCH v2 1/2] pretty: add X-Change-ID to mail formats

From: Drew DeVault <drew@ddevault.org>
Date: Jul 7, 2025, 07:12 UTC
Message-ID: <DB5MWRN5WUCZ.1DZ2SZ6WT3981@ddevault.org>
In-Reply-To: <CAESOdVAGEBCYOnFGUFojRk=6s=7RHc0i2jzuOVdBd91dXsCTEQ@mail.gmail.com>

On Mon Jul 7, 2025 at 8:57 AM CEST, Martin von Zweigbergk wrote:

Show 6 quoted lines

> +1
>
> Does this also apply to commit signatures? I just created a signed
> commit and checked what `git format-patch` produces. I was a bit
> surprised to see that it doesn't seem to show up anywhere. Is it not
> supported or did I miss some flag or config?

There is, to the best of my understanding, no serious effort being made towards causing commit signatures to survive the git-format-patch/git-am process. There's also some confusion that often occurs here because commit signatures are unrelated to PGP signatures and it is not possible to make either system meaningfully aware of the other.

Show 8 quoted lines

>> > In such a case, I fully agree that embedding in an e-mail header
>> > would be the way to go.
>
> Is it another option to put it somewhere in the body? Could we fit
> additional headers (e.g. signatures and third-party ones) somewhere
> between the `---` line and the additional diff? Or how about after the
> final `--` line? I haven't checked the specification. I just saw these
> lines in the `git format-patch` output.

I really think that it would be much wiser of us to put it in the email headers, which already exist as a well-defined structured data format for this purpose, rather than introduce something like commit trailers to the timely commentary section.