From: Drew DeVault Date: Mon, 07 Jul 2025 07:12:04 GMT Subject: Re: [PATCH v2 1/2] pretty: add X-Change-ID to mail formats Message-ID: In-Reply-To: On Mon Jul 7, 2025 at 8:57 AM CEST, Martin von Zweigbergk wrote: > +1 > > Does this also apply to commit signatures? I just created a signed > commit and checked what `git format-patch` produces. I was a bit > surprised to see that it doesn't seem to show up anywhere. Is it not > supported or did I miss some flag or config? There is, to the best of my understanding, no serious effort being made towards causing commit signatures to survive the git-format-patch/git-am process. There's also some confusion that often occurs here because commit signatures are unrelated to PGP signatures and it is not possible to make either system meaningfully aware of the other. >> > In such a case, I fully agree that embedding in an e-mail header >> > would be the way to go. > > Is it another option to put it somewhere in the body? Could we fit > additional headers (e.g. signatures and third-party ones) somewhere > between the `---` line and the additional diff? Or how about after the > final `--` line? I haven't checked the specification. I just saw these > lines in the `git format-patch` output. I really think that it would be much wiser of us to put it in the email headers, which already exist as a well-defined structured data format for this purpose, rather than introduce something like commit trailers to the timely commentary section.