Re: [PATCH v2 1/2] pretty: add X-Change-ID to mail formats

From: Aditya Garg <gargaditya08@live.com>
Date: Jul 6, 2025, 06:20 UTC
Message-ID: <PN3PR01MB9597069B8CF014BFE01B53F3B84CA@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
In-Reply-To: <20250703113505.11889-1-drew@ddevault.org>

On 03-07-2025 04:59 pm, Drew DeVault wrote:

Show 17 quoted lines

> Introduce the X-Change-ID header to emails prepared by git (i.e. via
> format-patch, send-email). This allows tools which work with those
> emails (e.g. patchwork, sourcehut) to meaningfully integrate with tools
> that assign change IDs to commits.
> 
> With some follow-up work, this is also the first step towards ensuring
> that those change IDs are preserved through from git-send-email to
> git-am as a change moves through its review lifecycle.
> 
> Signed-off-by: Drew DeVault <drew@ddevault.org>
> ---
> v2 is unchanged from v1.
> 
> One remark that occurs to me upon spinning v2 is that I'm not sure how
> to test this behavior. There is no obvious way to cause git upstream to
> produce a commit with a change-id -- presently these are only ever added
> by third-party tools.

I don't think we should add it to email headers. There are many email providers which do not allow custom headers in the emails. For example if you are using protonmail bridge or any third party protonmail client, the headers are not preserved. Similarly, if you are using MS Graph to send emails, headers are again not preserved. We should also consider cases when people use Thunderbird, Mutt or something similar to send emails, rather than git send-email.

The headers IMO should include the standard ones like From, Subject etc. Custom headers should be a part of body, just like we do Signed-off-by, Link etc.