Re: [PATCH v2 1/5] convert: quote filter names in error messages
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- Jul 28, 2016, 08:23 UTC
- Message-ID
- <DAD9422F-43EF-4F98-A373-87BCF5C1FCD1@gmail.com>
- In-Reply-To
- <57991329.1000709@gmail.com>
Show 15 quoted lines
> On 27 Jul 2016, at 22:01, Jakub Narębski <jnareb@gmail.com> wrote: > > W dniu 2016-07-27 o 02:06, larsxschneider@gmail.com pisze: > >> Git filter with spaces (e.g. `filter.sh foo`) are hard to read in >> error messages. Quote them to improve the readability. > > This is not something very important, but the above commit message > feels a bit clunky to me. The change is easy to understand, though, > so the commit message style is not that important. > > Perhaps "Git filter driver command with spaces"? > > Well, nevermind; if you have a better idea, good. If not, it is > good enough, IMHO.
Agreed. I will fix this with the next roll.
Thanks, Lars