Re: [PATCH v1 3/3] convert: add filter.<driver>.useProtocol option

From: Jeff King <peff@peff.net>
Date: Jul 26, 2016, 20:00 UTC
Message-ID: <20160726200028.GA21194@sigill.intra.peff.net>
In-Reply-To: <20160723072721.GA20875@starla>

On Sat, Jul 23, 2016 at 07:27:21AM +0000, Eric Wong wrote:

Show 12 quoted lines

> Jakub Narębski <jnareb@gmail.com> wrote:
> > W dniu 2016-07-22 o 17:49, larsxschneider@gmail.com pisze:
> > > +use strict;
> > > +use warnings;
> > > +use autodie;
> > 
> > autodie?
> 
> "set -e" for Perl (man autodie)
> 
> It's been a part of Perl for ages, but I've never used it
> myself, either; I suppose it's fine for tests...

autodie has been around for a long time, but it only became part of the perl core in v5.10.1 (according to Module::CoreList). I think the code in perl/ requires only 5.8, but whenever we unconditionally use perl without respect to NO_PERL (like in the test scripts), we usually shoot for even antique versions of perl like 5.005.

So by those rules, we should avoid "autodie" here, though I wouldn't be surprised if it takes a while for people to complain in practice (most modern systems will have a recent enough perl, but it seems we go through cycles where every few years somebody posts a bunch of patches for ancient versions of IRIX or some other platform, cleaning up all of these sorts of portability problems).

-Peff