Re: t5000-tar-tree.sh failing
- From
Brian Gernhardt <benji@silverinsanity.com>
- Date
- Dec 21, 2006, 23:37 UTC
- Message-ID
- <D8B2508E-D9EE-43F8-BAEE-BE7E5B446132@silverinsanity.com>
- In-Reply-To
- <20061221185948.GA27072@informatik.uni-freiburg.de>
On Dec 21, 2006, at 1:59 PM, Uwe Kleine-Koenig wrote:
Show 8 quoted lines
> I'm not sure if (in this case) a missing unzip should be as silent as > you suggest. The danger is, that s.o. makes a change, runs `make > test` > and is then conviced that nothing broke. So I think that the test > should fail, but with a more descriptive error than it is now. > > The downside is, you need unzip, svn, what ever more to run the test > suite.
I was attempting to say that if we're skipping tests we should say so, and not just drop them silently like the code that Johannes posted. Really, I guess the ideal would be for there to be a test harness that would run all the tests and report skips and errors in a report at the end rather than in the middle.
~~ Brian