t5000-tar-tree.sh failing

From: Uwe Kleine-König <zeisberg@informatik.uni-freiburg.de>
Date: Dec 21, 2006, 13:37 UTC
Message-ID: <20061221133746.GA13751@cepheus>

Hello,

when I run make test, I get:

	*** t5000-tar-tree.sh ***
	Initialized empty Git repository in .git/
	*   ok 1: populate workdir
	*   ok 2: add files to repository
	*   ok 3: git-tar-tree
	*   ok 4: validate file modification time
	*   ok 5: git-get-tar-commit-id
	*   ok 6: extract tar archive
	*   ok 7: validate filenames
	*   ok 8: validate file contents
	*   ok 9: git-tar-tree with prefix
	*   ok 10: extract tar archive with prefix
	*   ok 11: validate filenames with prefix
	*   ok 12: validate file contents with prefix
	*   ok 13: git-archive --format=zip
	* FAIL 14: extract ZIP archive
		(mkdir d && cd d && $UNZIP ../d.zip)
	* FAIL 15: validate filenames
		(cd d/a && find .) | sort >d.lst &&
		     diff a.lst d.lst
	* FAIL 16: validate file contents
		diff -r a d/a
	*   ok 17: git-archive --format=zip with prefix
	* FAIL 18: extract ZIP archive with prefix
		(mkdir e && cd e && $UNZIP ../e.zip)
	* FAIL 19: validate filenames with prefix
		(cd e/prefix/a && find .) | sort >e.lst &&
		     diff a.lst e.lst
	* FAIL 20: validate file contents with prefix
		diff -r a e/prefix/a
	* failed 6 among 20 test(s)

I think the problem is:

	zeisberg@cepheus:~/gsrc/git$ unzip
	bash: unzip: command not found

Probably the subversion tests suffer the same (for svn instead of unzip).

Do we want the tests to depend on all that or would it be sensible to output a warning that a program is missing? Or maybe introduce test "13.5: check is unzip is available". Then it would be more obvious for the tester what went wrong?

Best regards Uwe

-- 
Uwe Kleine-König

primes where sieve (p:xs) = [ x | x<-xs, x `rem` p /= 0 ]; \
primes = map head (iterate sieve [2..])