git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t5000-tar-tree.sh failing

From
Uwe Kleine-Koenig <zeisberg@informatik.uni-freiburg.de>
Date
Dec 21, 2006, 18:59 UTC
Message-ID
<20061221185948.GA27072@informatik.uni-freiburg.de>
In-Reply-To
<9A725DAA-FAA8-4779-A73D-ED117CC068C1@silverinsanity.com>
Hello,
Brian Gernhardt wrote:
Show 21 quoted lines
> Several other test frameworks provide a "skip" method to indicate why  
> we've skipped something.  We could do something similar...
> 
> if skip 'unzip -h' 'tests need unzip'; then
>    # unzip tests
> fi
> 
> skip() {
>   # Have not checked to see if this is anything resembling working code
>   if eval $1 > /dev/null 2>&1; then
>     true
>   else
>     echo "* skipping tests: $2" 1>&2
>     false
>   fi
> }
> 
> Mostly so that skipped tests are obvious, provide a reason, and have  
> a standardized display format.  Again, too busy in actual work to try  
> to do this myself right now, but might hack at it this afternoon if  
> nobody else (hopefully someone more fluent in shell than I am) does.

I'm not sure if (in this case) a missing unzip should be as silent as you suggest. The danger is, that s.o. makes a change, runs `make test` and is then conviced that nothing broke. So I think that the test should fail, but with a more descriptive error than it is now.

The downside is, you need unzip, svn, what ever more to run the test suite.

Best regards Uwe

-- 
Uwe Kleine-Koenig

http://www.google.com/search?q=gigabyte+in+bit
Previous: Brian GernhardtNext: Brian Gernhardt
Message 4 of 6 in “t5000-tar-tree.sh failing”
  1. Uwe Kleine-KönigDec 21, 2006
  2. Johannes SchindelinDec 21, 2006
  3. Brian GernhardtDec 21, 2006
  4. Uwe Kleine-KoenigDec 21, 2006
  5. Brian GernhardtDec 21, 2006
  6. Johannes SchindelinDec 22, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.