Re: [spf:guess,mismatch] [PATCH v2] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.
- From
Yoshioka Tsuneo <yoshiokatsuneo@gmail.com>
- Date
- Oct 12, 2013, 20:52 UTC
- Message-ID
- <D89D1A4D-B9B0-483C-BDBB-BC6CAF6A4D2E@gmail.com>
- In-Reply-To
- <87mwmfyru4.fsf@gmail.com>
Hello
On Oct 12, 2013, at 8:35 AM, Keshav Kini <keshav.kini@gmail.com> wrote:
Show 13 quoted lines
> Sam Vilain <sam@vilain.net> writes: > >> On 10/11/2013 06:07 AM, Yoshioka Tsuneo wrote: >>> + prefix_len = ((prefix_len >= 0) ? prefix_len : 0); >>> + strncpy(pre_arrow, arrow - prefix_len, prefix_len); >>> + pre_arrow[prefix_len] = '¥0'; >> >> >> This seems to be an encoding mistake; was this supposed to be an ASCII >> arrow? > > That's supposed to be a null terminator character, '\0'. See > https://en.wikipedia.org/wiki/Yen_symbol#Code_page_932
Thank you for pointing out the encoding issue. It looks, I need to change encoding of "pbcopy" command to "en_US.UTF-8" from "C" on Mac OS X. I just sent updated patch as "PATCH v3".
Thanks !
--- Tsuneo Yoshioka (吉岡 恒夫) yoshiokatsuneo@gmail.com
On Oct 12, 2013, at 8:35 AM, Keshav Kini <keshav.kini@gmail.com> wrote:
Show 20 quoted lines
> Sam Vilain <sam@vilain.net> writes: > >> On 10/11/2013 06:07 AM, Yoshioka Tsuneo wrote: >>> + prefix_len = ((prefix_len >= 0) ? prefix_len : 0); >>> + strncpy(pre_arrow, arrow - prefix_len, prefix_len); >>> + pre_arrow[prefix_len] = '¥0'; >> >> >> This seems to be an encoding mistake; was this supposed to be an ASCII >> arrow? > > That's supposed to be a null terminator character, '\0'. See > https://en.wikipedia.org/wiki/Yen_symbol#Code_page_932 > > -Keshav > > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html