Re: [PATCH v6] diff.c: keep arrow(=>) on show_stats()'s shortened filename part to make rename visible.
- From
Yoshioka Tsuneo <yoshiokatsuneo@gmail.com>
- Date
- Oct 18, 2013, 09:35 UTC
- Message-ID
- <21F30E1F-3497-41F2-81C4-F4193C58FE11@gmail.com>
- In-Reply-To
- <xmqqzjq7wmj7.fsf@gitster.dls.corp.google.com>
Hello Junio
Show 13 quoted lines
>> In the "[PATCH v7]", I changed to keep filename part of suffix to handle
>> above case, but not always keep directory part because I feel totally
>> keeping all part of long suffix including directory name may cause output like:
>> …{… => …}…ongPath1/LongPath2/nameOfTheFileThatWasMoved
>> And, above may be worse than:
>> ...{...ceDirectory => …ionDirectory}.../nameOfTheFileThatWasMoved
>> I think.
>
> I am not sure if I agree.
>
> Losing LongPath2 part may be more significant data loss than losing
> a single bit that says the change is a rename, as the latter may not
> quite tell us what these two directories were anyway.I'm not sure which is the better in general. But anyway, I don't have strong opinion about this. So, I just changed to keep the all of the <sfx> part(lator than '}'). I just sent the updated patch as "[PATCH v8]".
Thanks !
--- Tsuneo Yoshioka (吉岡 恒夫) yoshiokatsuneo@gmail.com
On Oct 18, 2013, at 1:38 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 15 quoted lines
> Yoshioka Tsuneo <yoshiokatsuneo@gmail.com> writes:
>
>> In the "[PATCH v7]", I changed to keep filename part of suffix to handle
>> above case, but not always keep directory part because I feel totally
>> keeping all part of long suffix including directory name may cause output like:
>> …{… => …}…ongPath1/LongPath2/nameOfTheFileThatWasMoved
>> And, above may be worse than:
>> ...{...ceDirectory => …ionDirectory}.../nameOfTheFileThatWasMoved
>> I think.
>
> I am not sure if I agree.
>
> Losing LongPath2 part may be more significant data loss than losing
> a single bit that says the change is a rename, as the latter may not
> quite tell us what these two directories were anyway.