git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 00/23] Signed push

From
Jaime Soriano Pastor <jsorianopastor@gmail.com>
Date
Sep 16, 2014, 18:16 UTC
Message-ID
<CAPuZ2NFw_NM2EYFkiMQDAwuPBSh1_3JUH13hMN4Rox5eJf-L1w@mail.gmail.com>
In-Reply-To
<1410819864-22967-1-git-send-email-gitster@pobox.com>
On Tue, Sep 16, 2014 at 12:24 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
> A failing test has been added at the end for smart HTTP.  It appears
> that somewhere in the callchain "--signed" is forgotten and the
> sending end not to send the certificate for some reason.  If
> somebody with a fresh set of eyes can look into it, that would be
> very much appreciated, as I do not expect I would have sufficient
> concentration to dig it quickly for several days at least.
>

It seems that smart HTTP is using "git send-pack" (called from push_git()), that doesn't still know anything about signed pushes. I think this is the point where the flag is forgotten.

Previous: Junio C HamanoNext: Junio C Hamano
Message 25 of 27 in “Signed push”
  1. 00/23 Signed pushJunio C Hamano, Sep 15, 2014
  2. 01/23 receive-pack: do not overallocate command structureJunio C Hamano, Sep 15, 2014
  3. 02/23 receive-pack: parse feature request a bit earlierJunio C Hamano, Sep 15, 2014
  4. 03/23 receive-pack: do not reuse old_sha1[] for other thingsJunio C Hamano, Sep 15, 2014
  5. 04/23 receive-pack: factor out queueing of commandJunio C Hamano, Sep 15, 2014
  6. 05/23 send-pack: move REF_STATUS_REJECT_NODELETE logic a bit higherJunio C Hamano, Sep 15, 2014
  7. 06/23 send-pack: refactor decision to send update per refJunio C Hamano, Sep 15, 2014
  8. 07/23 send-pack: always send capabilitiesJunio C Hamano, Sep 15, 2014
  9. 08/23 send-pack: factor out capability string generationJunio C Hamano, Sep 15, 2014
  10. 09/23 receive-pack: factor out capability string generationJunio C Hamano, Sep 15, 2014
  11. 10/23 send-pack: rename "new_refs" to "need_pack_data"Junio C Hamano, Sep 15, 2014
  12. 11/23 send-pack: refactor inspecting and resetting status and sending commandsJunio C Hamano, Sep 15, 2014
  13. 12/23 send-pack: clarify that cmds_sent is a booleanJunio C Hamano, Sep 15, 2014
  14. 13/23 gpg-interface: move parse_gpg_output() to where it should beJunio C Hamano, Sep 15, 2014
  15. 14/23 gpg-interface: move parse_signature() to where it should beJunio C Hamano, Sep 15, 2014
  16. 15/23 pack-protocol doc: typofix for PKT-LINEJunio C Hamano, Sep 15, 2014
  17. 16/23 push: the beginning of "git push --signed"Junio C Hamano, Sep 15, 2014
  18. 17/23 receive-pack: GPG-validate push certificatesJunio C Hamano, Sep 15, 2014
  19. 18/23 send-pack: send feature request on push-cert packetJunio C Hamano, Sep 15, 2014
  20. 19/23 signed push: remove duplicated protocol infoJunio C Hamano, Sep 15, 2014
  21. 20/23 signed push: add "pushee" header to push certificateJunio C Hamano, Sep 15, 2014
  22. 21/23 signed push: fortify against replay attacksJunio C Hamano, Sep 15, 2014
  23. 22/23 signed push: allow stale nonce in stateless modeJunio C Hamano, Sep 15, 2014
  24. 23/23 t5541: test push --signed to smart HTTP serverJunio C Hamano, Sep 15, 2014
  25. Jaime Soriano PastorSep 16, 2014
  26. Junio C HamanoSep 16, 2014
  27. Eric SunshineSep 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.