git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 23/23] t5541: test push --signed to smart HTTP server

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 15, 2014, 22:24 UTC
Message-ID
<1410819864-22967-24-git-send-email-gitster@pobox.com>
In-Reply-To
<1410819864-22967-1-git-send-email-gitster@pobox.com>

Currently it seems that somewhere in the transport option setting chain the "--signed" bit gets lost and this does not pass.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t5541-http-push-smart.sh | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)
diff --git a/t/t5541-http-push-smart.sh b/t/t5541-http-push-smart.sh
index 73af16f..3915f67 100755
--- a/t/t5541-http-push-smart.sh
+++ b/t/t5541-http-push-smart.sh
@@ -14,6 +14,7 @@ fi
 ROOT_PATH="$PWD"
 . "$TEST_DIRECTORY"/lib-httpd.sh
 . "$TEST_DIRECTORY"/lib-terminal.sh
+. "$TEST_DIRECTORY"/lib-gpg.sh
 start_httpd
 
 test_expect_success 'setup remote repository' '
@@ -323,5 +324,43 @@ test_expect_success 'push into half-auth-complete requires password' '
 	test_cmp expect actual
 '
 
+test_expect_failure GPG 'push with post-receive to inspect certificate' '
+	(
+		cd "$HTTPD_DOCUMENT_ROOT_PATH"/test_repo.git &&
+		mkdir -p hooks &&
+		write_script hooks/post-receive <<-\EOF &&
+		# discard the update list
+		cat >/dev/null
+		# record the push certificate
+		if test -n "${GIT_PUSH_CERT-}"
+		then
+			git cat-file blob $GIT_PUSH_CERT >../push-cert
+		fi &&
+		env >../env &&
+		cat >../push-cert-status <<E_O_F
+		SIGNER=${GIT_PUSH_CERT_SIGNER-nobody}
+		KEY=${GIT_PUSH_CERT_KEY-nokey}
+		STATUS=${GIT_PUSH_CERT_STATUS-nostatus}
+		NONCE=${GIT_PUSH_CERT_NONCE-nononce}
+		E_O_F
+		EOF
+
+		git config receive.certnonceseed sekrit
+	) &&
+	cd "$ROOT_PATH/test_repo_clone" &&
+	test_commit cert-test &&
+	git push --signed "$HTTPD_URL/smart/test_repo.git" &&
+	(
+		cd "$HTTPD_DOCUMENT_ROOT_PATH" &&
+		cat <<-\EOF &&
+		SIGNER=C O Mitter <committer@example.com>
+		KEY=13B6F51ECDDE430D
+		STATUS=G
+		EOF
+		sed -n -e "s/^nonce /NONCE=/p" -e "/^$/q" push-cert
+	) >expect &&
+	test_cmp expect "$HTTPD_DOCUMENT_ROOT_PATH/push-cert-status"
+'
+
 stop_httpd
 test_done
-- 
2.1.0-410-gd72dacd
Previous: Junio C HamanoNext: Jaime Soriano Pastor
Message 24 of 27 in “Signed push”
  1. 00/23 Signed pushJunio C Hamano, Sep 15, 2014
  2. 01/23 receive-pack: do not overallocate command structureJunio C Hamano, Sep 15, 2014
  3. 02/23 receive-pack: parse feature request a bit earlierJunio C Hamano, Sep 15, 2014
  4. 03/23 receive-pack: do not reuse old_sha1[] for other thingsJunio C Hamano, Sep 15, 2014
  5. 04/23 receive-pack: factor out queueing of commandJunio C Hamano, Sep 15, 2014
  6. 05/23 send-pack: move REF_STATUS_REJECT_NODELETE logic a bit higherJunio C Hamano, Sep 15, 2014
  7. 06/23 send-pack: refactor decision to send update per refJunio C Hamano, Sep 15, 2014
  8. 07/23 send-pack: always send capabilitiesJunio C Hamano, Sep 15, 2014
  9. 08/23 send-pack: factor out capability string generationJunio C Hamano, Sep 15, 2014
  10. 09/23 receive-pack: factor out capability string generationJunio C Hamano, Sep 15, 2014
  11. 10/23 send-pack: rename "new_refs" to "need_pack_data"Junio C Hamano, Sep 15, 2014
  12. 11/23 send-pack: refactor inspecting and resetting status and sending commandsJunio C Hamano, Sep 15, 2014
  13. 12/23 send-pack: clarify that cmds_sent is a booleanJunio C Hamano, Sep 15, 2014
  14. 13/23 gpg-interface: move parse_gpg_output() to where it should beJunio C Hamano, Sep 15, 2014
  15. 14/23 gpg-interface: move parse_signature() to where it should beJunio C Hamano, Sep 15, 2014
  16. 15/23 pack-protocol doc: typofix for PKT-LINEJunio C Hamano, Sep 15, 2014
  17. 16/23 push: the beginning of "git push --signed"Junio C Hamano, Sep 15, 2014
  18. 17/23 receive-pack: GPG-validate push certificatesJunio C Hamano, Sep 15, 2014
  19. 18/23 send-pack: send feature request on push-cert packetJunio C Hamano, Sep 15, 2014
  20. 19/23 signed push: remove duplicated protocol infoJunio C Hamano, Sep 15, 2014
  21. 20/23 signed push: add "pushee" header to push certificateJunio C Hamano, Sep 15, 2014
  22. 21/23 signed push: fortify against replay attacksJunio C Hamano, Sep 15, 2014
  23. 22/23 signed push: allow stale nonce in stateless modeJunio C Hamano, Sep 15, 2014
  24. 23/23 t5541: test push --signed to smart HTTP serverJunio C Hamano, Sep 15, 2014
  25. Jaime Soriano PastorSep 16, 2014
  26. Junio C HamanoSep 16, 2014
  27. Eric SunshineSep 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.