[PATCH v5 00/23] Signed push
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 15, 2014, 22:24 UTC
- Message-ID
- <1410819864-22967-1-git-send-email-gitster@pobox.com>
The first round is found at $gmane/255520. The second round is found at $gmane/255701. The third round is found at $gmane/256464. The forth round is found at $gmane/256518.
Not much had to have changed since the last round, except for the hooks used in the test that have been fixed to slurp all its input in.
A failing test has been added at the end for smart HTTP. It appears that somewhere in the callchain "--signed" is forgotten and the sending end not to send the certificate for some reason. If somebody with a fresh set of eyes can look into it, that would be very much appreciated, as I do not expect I would have sufficient concentration to dig it quickly for several days at least.
Junio C Hamano (23):
receive-pack: do not overallocate command structure
receive-pack: parse feature request a bit earlier
receive-pack: do not reuse old_sha1[] for other things
receive-pack: factor out queueing of command
send-pack: move REF_STATUS_REJECT_NODELETE logic a bit higher
send-pack: refactor decision to send update per ref
send-pack: always send capabilities
send-pack: factor out capability string generation
receive-pack: factor out capability string generation
send-pack: rename "new_refs" to "need_pack_data"
send-pack: refactor inspecting and resetting status and sending
commands
send-pack: clarify that cmds_sent is a boolean
gpg-interface: move parse_gpg_output() to where it should be
gpg-interface: move parse_signature() to where it should be
pack-protocol doc: typofix for PKT-LINE
push: the beginning of "git push --signed"
receive-pack: GPG-validate push certificates
send-pack: send feature request on push-cert packet
signed push: remove duplicated protocol info
signed push: add "pushee" header to push certificate
signed push: fortify against replay attacks
signed push: allow stale nonce in stateless mode
t5541: test push --signed to smart HTTP serverDocumentation/config.txt | 6 + Documentation/git-push.txt | 9 +- Documentation/git-receive-pack.txt | 63 +++- Documentation/technical/pack-protocol.txt | 49 ++- Documentation/technical/protocol-capabilities.txt | 13 +- builtin/push.c | 1 + builtin/receive-pack.c | 354 +++++++++++++++++++--- commit.c | 36 --- gpg-interface.c | 57 ++++ gpg-interface.h | 17 +- send-pack.c | 201 +++++++++--- send-pack.h | 2 + t/t5534-push-signed.sh | 125 ++++++++ t/t5541-http-push-smart.sh | 39 +++ tag.c | 20 -- tag.h | 1 - transport.c | 5 + transport.h | 5 + 18 files changed, 847 insertions(+), 156 deletions(-) create mode 100755 t/t5534-push-signed.sh
-- 2.1.0-410-gd72dacd