Re: [PATCH 0/3] fix failing t4301 test and &&-chain breakage

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 30, 2022, 02:56 UTC
Message-ID: <CAPig+cTNaE8sBRyMqMzRiE7+RMwaFEUNPuArr8dvrOrRzq-QFA@mail.gmail.com>
In-Reply-To: <CABPp-BGTdqo9rBoWYeOp+ATU1NS+GFzBcdPnMPGgH0_Jksr7zA@mail.gmail.com>

On Mon, Aug 29, 2022 at 10:53 PM Elijah Newren <newren@gmail.com> wrote:

Show 9 quoted lines

> On Sun, Aug 28, 2022 at 1:05 PM Junio C Hamano <gitster@pobox.com> wrote:
> > >   t4301: account for behavior differences between sed implementations
> > >   t4031: fix broken &&-chains and add missing loop termination
> > >   t4301: emit blank line in more idiomatic fashion
> >
> > The second one is off by 270.
>
> Apparently Eric knew what you meant, but I'm perplexed by this
> statement and what it means.  What am I missing?

Junio's comment was opaque to me, as well, and it took several minutes to figure it out (especially since I authored the patches, thus I read what I expected to read, not what was really there). Taking a look at just prefixes on the patch subject lines...

    t4301
    t4031
    t4301

there's a transposition in there which, mathematically speaking, makes one of the test script numbers 270 less than the others.