git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] fix failing t4301 test and &&-chain breakage

From
Elijah Newren <newren@gmail.com>
Date
Aug 30, 2022, 02:52 UTC
Message-ID
<CABPp-BGBEfFh0z0YHGcHE+rva9JdapXprPn-RSmif0xn6fcxYw@mail.gmail.com>
In-Reply-To
<pull.1339.git.1661663879.gitgitgadget@gmail.com>

On Sat, Aug 27, 2022 at 10:18 PM Eric Sunshine via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 13 quoted lines
>
> This series fixes a failing test in t4301 due to 'sed' behavioral
> differences between implementations. It also fixes a couple broken &&-chains
> and adds missing explicit loop termination.
>
> The third patch is entirely subjective and can be dropped if unwanted. I
> spent more than a few minutes puzzling over the script's use of 'printf
> "\\n"' rather than the more typical 'printf "\n"' or even a simple 'echo',
> wondering if there was some subtlety I was missing or whether Elijah had
> encountered an unusual situation in which '\\n' was needed over '\n'. The
> third patch chooses to replace 'printf "\\n"' with 'echo' which I find more
> idiomatic, but I can see value in using 'printf "\n"' as perhaps being
> clearer that it is adding a newline where one is missing.

I can't actually provide the reasoning for it; I took Dscho's testcase from [1] and used it as a basis for adding several other testcases. When I was copying & pasting and adjusting, I just didn't notice the 'printf "\\n"'. But using a simple echo makes sense.

[1] https://lore.kernel.org/git/3b4ed8bb1bb615277ee51a7b2af5fc53bae0a6e4.1660892256.git.gitgitgadget@gmail.com/
Anyway, I've read through the patches and your series looks good to me.
Previous: Elijah NewrenNext: Johannes Schindelin
Message 11 of 12 in “fix failing t4301 test and &&-chain breakage”
  1. 0/3 fix failing t4301 test and &&-chain breakageEric Sunshine via GitGitGadget, Aug 28, 2022
  2. 1/3 t4301: account for behavior differences between sed implementationsEric Sunshine via GitGitGadget, Aug 28, 2022
  3. 2/3 t4031: fix broken &&-chains and add missing loop terminationEric Sunshine via GitGitGadget, Aug 28, 2022
  4. 3/3 t4301: emit blank line in more idiomatic fashionEric Sunshine via GitGitGadget, Aug 28, 2022
  5. Junio C HamanoAug 28, 2022
  6. Eric SunshineAug 28, 2022
  7. Junio C HamanoAug 29, 2022
  8. Elijah NewrenAug 30, 2022
  9. Eric SunshineAug 30, 2022
  10. Elijah NewrenAug 30, 2022
  11. Elijah NewrenAug 30, 2022
  12. Johannes SchindelinAug 30, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.