Re: [Patch v1 2/3] t5318: replace use of /dev/zero with generate_zero_bytes
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Feb 10, 2019, 02:07 UTC
- Message-ID
- <CAPig+cTMoYMmnHVuay_4RGr_FN-HWC1tN4TPDsNM4vKCH3GzXw@mail.gmail.com>
- In-Reply-To
- <20190209185930.5256-3-randall.s.becker@rogers.com>
On Sat, Feb 9, 2019 at 2:00 PM <randall.s.becker@rogers.com> wrote:
> This change removes the dependency on /dev/zero with generate_zero_bytes > appending NUL values to blocks generating wrong signatures for test cases.
This commit message says what the patch does but not _why_. At minimum, it should explain that /dev/zero is not available on all platforms, therefore, not portable, and (perhaps) cite NonStop as an example.
Show 6 quoted lines
> Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
> ---
> diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh
> @@ -383,7 +383,7 @@ corrupt_graph_and_verify() {
> - dd if=/dev/zero of="$objdir/info/commit-graph" bs=1 seek="$zero_pos" count=$(($orig_size - $zero_pos)) &&
> + generate_zero_bytes $(($orig_size - $zero_pos)) >> "$objdir/info/commit-graph" &&