git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[Patch v1 2/3] t5318: replace use of /dev/zero with generate_zero_bytes

From
Rrandall.s.becker@rogers.com <randall.s.becker@rogers.com>
Date
Feb 9, 2019, 18:59 UTC
Message-ID
<20190209185930.5256-3-randall.s.becker@rogers.com>
In-Reply-To
<20190209185930.5256-1-randall.s.becker@rogers.com>
From: "Randall S. Becker" <rsbecker@nexbridge.com>

This change removes the dependency on /dev/zero with generate_zero_bytes appending NUL values to blocks generating wrong signatures for test cases.

Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
---
 t/t5318-commit-graph.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh
index 16d10ebce..65c1f45b0 100755
--- a/t/t5318-commit-graph.sh
+++ b/t/t5318-commit-graph.sh
@@ -383,7 +383,7 @@ corrupt_graph_and_verify() {
 	cp $objdir/info/commit-graph commit-graph-backup &&
 	printf "$data" | dd of="$objdir/info/commit-graph" bs=1 seek="$pos" conv=notrunc &&
 	dd of="$objdir/info/commit-graph" bs=1 seek="$zero_pos" count=0 &&
-	dd if=/dev/zero of="$objdir/info/commit-graph" bs=1 seek="$zero_pos" count=$(($orig_size - $zero_pos)) &&
+	generate_zero_bytes $(($orig_size - $zero_pos)) >> "$objdir/info/commit-graph" &&
 	test_must_fail git commit-graph verify 2>test_err &&
 	grep -v "^+" test_err >err &&
 	test_i18ngrep "$grepstr" err
-- 
2.12.3
Previous: Junio C HamanoNext: Eric Sunshine
Message 18 of 24 in “2.21.0-rc0 test fixes resulting from use of /dev/zero”
  1. 0/3 2.21.0-rc0 test fixes resulting from use of /dev/zerorandall.s.becker@rogers.com, Feb 9, 2019
  2. 1/3 test-lib-functions.sh: add generate_zero_bytes functionrandall.s.becker@rogers.com, Feb 9, 2019
  3. Eric SunshineFeb 10, 2019
  4. Randall S. BeckerFeb 10, 2019
  5. Jeff KingFeb 12, 2019
  6. Eric SunshineFeb 12, 2019
  7. randall.s.becker@rogers.comFeb 12, 2019
  8. 3/3 t5562: replace /dev/zero with a pipe from generate_zero_bytesrandall.s.becker@rogers.com, Feb 9, 2019
  9. Eric SunshineFeb 10, 2019
  10. Junio C HamanoFeb 12, 2019
  11. Johannes SixtFeb 12, 2019
  12. Junio C HamanoFeb 13, 2019
  13. t5562: do not depend on /dev/zeroMax Kirillov, Feb 15, 2019
  14. Randall S. BeckerFeb 15, 2019
  15. Junio C HamanoFeb 15, 2019
  16. Randall S. BeckerFeb 15, 2019
  17. Junio C HamanoFeb 15, 2019
  18. 2/3 t5318: replace use of /dev/zero with generate_zero_bytesrandall.s.becker@rogers.com, Feb 9, 2019
  19. Eric SunshineFeb 10, 2019
  20. Junio C HamanoFeb 12, 2019
  21. Junio C HamanoFeb 13, 2019
  22. Randall S. BeckerFeb 13, 2019
  23. Junio C HamanoFeb 13, 2019
  24. Randall S. BeckerFeb 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.