Re: [PATCH] t: fix whitespace around &&

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 15, 2020, 18:20 UTC
Message-ID: <CAPig+cTGqEdr+rjRCfKmcm=ab3vKnUokd6KyrsoBiy=AO9nnOQ@mail.gmail.com>
In-Reply-To: <20200315180902.13750-1-rybak.a.v@gmail.com>

On Sun, Mar 15, 2020 at 2:09 PM Andrei Rybak <rybak.a.v@gmail.com> wrote:

Show 10 quoted lines

> Add missing spaces before '&&' and switch tabs to spaces.  Also fix the
> space after redirection operator in t3701-add-interactive.sh while we're
> here.  These issues were found using `git grep '[^ ]&&$'`.
>
> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
> ---
> diff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh
> @@ -348,7 +348,7 @@ test_expect_success \
> -        echo "To be changed and have mode changed" > 07-change-mode-change     &&
> +        echo "To be changed and have mode changed" > 07-change-mode-change &&

The commit message talks about dropping whitespace after the '>' redirection operator (and some of the changes in this patch do so), however, this change neglects that cleanup.

> @@ -361,7 +361,7 @@ test_expect_success \
> -        echo "Changed and have mode changed" > 07-change-mode-change   &&
> +        echo "Changed and have mode changed" > 07-change-mode-change &&

Ditto.