Re: [PATCH] t: fix whitespace around &&

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 15, 2020, 18:38 UTC
Message-ID: <CAPig+cSE-c8ax8MyPg3QsDhgvRWt1HGRkV3x6WXJWEUbJQ_yJA@mail.gmail.com>
In-Reply-To: <0ad0600c-d1fc-0f44-dae1-7bd0fc22b3e8@gmail.com>

On Sun, Mar 15, 2020 at 2:35 PM Andrei Rybak <rybak.a.v@gmail.com> wrote:

Show 12 quoted lines

> On 2020-03-15 19:20, Eric Sunshine wrote:
> > On Sun, Mar 15, 2020 at 2:09 PM Andrei Rybak <rybak.a.v@gmail.com> wrote:
> >> -        echo "To be changed and have mode changed" > 07-change-mode-change     &&
> >> +        echo "To be changed and have mode changed" > 07-change-mode-change &&
> >
> > The commit message talks about dropping whitespace after the '>'
> > redirection operator (and some of the changes in this patch do so),
> > however, this change neglects that cleanup.
>
> Good catch. t9500-gitweb-standalone-no-errors.sh has 35 of these vs 19
> redirects with correct formatting, so it might be better to fix those redirects
> in a separate patch. What do you think?

Yes, fixing it in a separate patch makes sense.