Re: [PATCH] t: fix whitespace around &&

From: Andrei Rybak <rybak.a.v@gmail.com>
Date: Mar 15, 2020, 18:35 UTC
Message-ID: <0ad0600c-d1fc-0f44-dae1-7bd0fc22b3e8@gmail.com>
In-Reply-To: <CAPig+cTGqEdr+rjRCfKmcm=ab3vKnUokd6KyrsoBiy=AO9nnOQ@mail.gmail.com>

On 2020-03-15 19:20, Eric Sunshine wrote:

Show 15 quoted lines

> On Sun, Mar 15, 2020 at 2:09 PM Andrei Rybak <rybak.a.v@gmail.com> wrote:
>> Add missing spaces before '&&' and switch tabs to spaces.  Also fix the
>> space after redirection operator in t3701-add-interactive.sh while we're
>> here.  These issues were found using `git grep '[^ ]&&$'`.
>>
>> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
>> ---
>> diff --git a/t/t9500-gitweb-standalone-no-errors.sh b/t/t9500-gitweb-standalone-no-errors.sh
>> @@ -348,7 +348,7 @@ test_expect_success \
>> -        echo "To be changed and have mode changed" > 07-change-mode-change     &&
>> +        echo "To be changed and have mode changed" > 07-change-mode-change &&
> 
> The commit message talks about dropping whitespace after the '>'
> redirection operator (and some of the changes in this patch do so),
> however, this change neglects that cleanup.

Good catch. t9500-gitweb-standalone-no-errors.sh has 35 of these vs 19 redirects with correct formatting, so it might be better to fix those redirects in a separate patch. What do you think?

Show 6 quoted lines

>> @@ -361,7 +361,7 @@ test_expect_success \
>> -        echo "Changed and have mode changed" > 07-change-mode-change   &&
>> +        echo "Changed and have mode changed" > 07-change-mode-change &&
> 
> Ditto.
>

Thanks for review.