Re: [PATCH v4 0/3] worktree: teach add to accept --reason with --lock

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jul 15, 2021, 17:17 UTC
Message-ID: <CAPig+cT6KJ9=9pOS9jiXd0XQYdD0j1aZSyy29WyJ4w3x1dvqhg@mail.gmail.com>
In-Reply-To: <pull.992.v4.git.1626316350.gitgitgadget@gmail.com>

On Wed, Jul 14, 2021 at 10:32 PM Stephen Manz via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 11 quoted lines

> The default reason stored in the lock file, "added with --lock", is unlikely
> to be what the user would have given in a separate git worktree lock
> command. Allowing --reason to be specified along with --lock when adding a
> working tree gives the user control over the reason for locking without
> needing a second command.
>
> Changes since v3:
>
>  * Updated test to define a shell variable, lock_reason, set to "why not".
>    Expand the variable to use with --reason and to echo to file, expected.
>    This avoids the spacing comment made by Eric Sunshine.

Thanks, these changes look fine to me. I don't know whether or not Junio has merged this series down to his "next" branch yet locally, though. If he has, then he may not pick up your v4, and this minor cleanup change could instead be done as a standalone patch atop v3 (or could be dropped since v3 was probably "good enough").

In any case, this series is still Reviewed-by: me.