Re: [PATCH v2 2/3] worktree: default lock string should be marked with `_()` for translation
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jul 9, 2021, 06:19 UTC
- Message-ID
- <CAPig+cRiEYcz8-F0FzQRetF9UoN1Di099JVgCz0920kQ3a+BwQ@mail.gmail.com>
- In-Reply-To
- <30196cc93697cd4a6a6881dcbb1073d19e96d8a0.1625759443.git.gitgitgadget@gmail.com>
On Thu, Jul 8, 2021 at 11:50 AM Stephen Manz via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 7 quoted lines
> diff --git a/builtin/worktree.c b/builtin/worktree.c
> @@ -305,7 +305,7 @@ static int add_worktree(const char *path, const char *refname,
> if (!opts->keep_locked)
> write_file(sb.buf, "initializing");
> else
> - write_file(sb.buf, "added with --lock");
> + write_file(sb.buf, _("added with --lock"));Makes perfect sense, though the "initializing" string in the `then` arm probably deserves the same treatment:
write_file(sb.buf, _("initializing"));