Re: [PATCH v4 0/3] worktree: teach add to accept --reason with --lock

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jul 17, 2021, 00:14 UTC
Message-ID: <CAPig+cSmkrQDDWgU-RTbAaswaGsG1xxgvOjxHjLc-8Bwgqk8wg@mail.gmail.com>
In-Reply-To: <CAPig+cT6KJ9=9pOS9jiXd0XQYdD0j1aZSyy29WyJ4w3x1dvqhg@mail.gmail.com>

On Thu, Jul 15, 2021 at 1:17 PM Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 13 quoted lines

> On Wed, Jul 14, 2021 at 10:32 PM Stephen Manz via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> > Changes since v3:
> >
> >  * Updated test to define a shell variable, lock_reason, set to "why not".
> >    Expand the variable to use with --reason and to echo to file, expected.
> >    This avoids the spacing comment made by Eric Sunshine.
>
> Thanks, these changes look fine to me. I don't know whether or not
> Junio has merged this series down to his "next" branch yet locally,
> though. If he has, then he may not pick up your v4, and this minor
> cleanup change could instead be done as a standalone patch atop v3 (or
> could be dropped since v3 was probably "good enough").

It looks like Junio did pick up v4, so no need for a standalone cleanup patch atop v3.