Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- May 26, 2015, 18:47 UTC
- Message-ID
- <CAPig+cT3-=05xpeBUMEo3cT8-i=EQKv=XD7cKPDPuLbsfQX2=g@mail.gmail.com>
- In-Reply-To
- <xmqqfv6nchmf.fsf@gitster.dls.corp.google.com>
On Sat, May 23, 2015 at 1:45 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 24 quoted lines
> Allen Hubbe <allenbh@gmail.com> writes: >> Note that this only adds support for a limited subset of the sendmail >> format. The format is is as follows. >> >> <alias>: <address|alias>[, <address|alias>...] >> >> Aliases are specified one per line, and must start on the first column of the >> line. Blank lines are ignored. If the first non whitespace character >> on a line is a '#' symbol, then the whole line is considered a comment, >> and is ignored. >> [...] >> Signed-off-by: Allen Hubbe <allenbh@gmail.com> >> --- > > Thanks. > > A small thing I noticed in the test (and this patch is not adding a > new "breakage"---there are a few existing instances) is the use of > "~/"; it should be spelled "$HOME/" instead for portability (not in > POSIX, even though bash, dash and ksh all seem to understand it). > > I think this round looks good from a cursory read. > > Eric, what do you think?
Sorry for the delay. This round looks much better. I do have a few very minor comments, which I'll post in reply to the patch itself, but nothing worth holding the series up. Thanks.