Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format
- From
Allen Hubbe <allenbh@gmail.com>
- Date
- May 25, 2015, 12:47 UTC
- Message-ID
- <CAJ80sas_D-6z4MvuFvvjoX7U_bM6b3brCo4rvYFCUfTmKS=6bA@mail.gmail.com>
- In-Reply-To
- <CAJ80savVjb3_iKhNWPjQNK72DL7eq5YkbjWWG-1Gkx5+LOjzeg@mail.gmail.com>
On Sat, May 23, 2015 at 6:24 PM, Allen Hubbe <allenbh@gmail.com> wrote:
Show 13 quoted lines
> On Sat, May 23, 2015 at 2:07 PM, Junio C Hamano <gitster@pobox.com> wrote: >> Junio C Hamano <gitster@pobox.com> writes: >> >>> A small thing I noticed in the test (and this patch is not adding a >>> new "breakage"---there are a few existing instances) is the use of >>> "~/"; it should be spelled "$HOME/" instead for portability (not in >>> POSIX, even though bash, dash and ksh all seem to understand it). >> >> Well, I was wrong. Tilde expansion is in POSIX. >> >> Nevertheless, I'd prefer if we avoided it. > > Alright, $HOME it will be.
Looking closer at this and the other test cases, they are inconsistent about using ".mailrc", "~/.mailrc", and "$(pwd)/.mailrc". This would add another one, "$HOME/.mailrc".
How do you feel about using just ".mailrc", and "$(pwd)/.mailrc" when an absolute path is needed in gitconfig?