Re: [PATCH v5 1/1] send-email: Add sendmail email aliases format

From: Allen Hubbe <allenbh@gmail.com>
Date: May 26, 2015, 02:16 UTC
Message-ID: <CAJ80sauoB-quepDf2V=-WqewzJ_nN+ALA-z-vcL_4c8rObxpBg@mail.gmail.com>
In-Reply-To: <xmqq1ti49k1a.fsf@gitster.dls.corp.google.com>

On Mon, May 25, 2015 at 9:58 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> Allen Hubbe <allenbh@gmail.com> writes:
>
>> Thanks for letting me know.  Are you still expecting v6 from me then?
>> The other thing you asked for was a change in the documentation: just
>> mention the email programs' documentation, and describe the
>> exceptions.
>
> Could you fetch from me and then run:
>
>  $ git log --reverse -3 -p 6b733ee4ba330e1187017895b8426dd9171c33b8
>
> to see if you agree with the result?  That is what I queued on 'pu'
> for now with my fixups.

It looks good to me. How would you like me to proceed? I assume you would like your patch on top of mine will stay, to use HOME instead of tilde. Or, would you like me to use HOME in my v6, too?

Should I send you v6 like v5, but with the documentation fixed, or would you now prefer a separate patch on top of that to fix the documentation? I can do either, and you would be welcome to rebase/fixup the second patch into the earlier one with my sign off.

Show 8 quoted lines

>
> We have not heard from Eric on this round yet, so he (and others)
> may have further input, but as far as I am concerned, that one
> looked more or less ready to be merged down to 'next', except for
> the documentation part, which I haven't had a chance to look at the
> results and may need further AsciiDoc mark-up fixes.
>
> Thanks.