Re: [PATCH 19/21] t9003: become resilient to GETTEXT_POISON
On Fri, May 20, 2016 at 12:39 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 24 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes:
>> Indeed, the sed seems superfluous. The output of the test command is:
>>
>> git: 'lfg' is not a git command. See 'git --help'.
>>
>> Did you mean this?
>> lgf
>>
>> And, the grep'd string, "lgf" only appears once, so grep alone should
>> be sufficient to verify expected behavior.
>
> Perhaps discarding up to the first blank line (i.e. assuming that we
> would not remove that blank, and also assuming that we will not
> rephrase "Did you mean this?") may be a good alternative.
>
> Or assuming that the explanatory text would not begin its lines with
> a tab, i.e.
>
> grep '^ lgf$' actual
>
> (the space between '^' and 'l' above is a TAB) without using
> test_i18ngrep?
>
> I think I like that the best among what I can think of offhand.
Yep, I also considered both of these approaches and favored the latter, as well.