Re: [PATCH v2 3/3] cache.h: eliminate SHA-1 deprecation warnings on OS X 10.8

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 12, 2013, 18:37 UTC
Message-ID: <CAPig+cSw5-S7MDhG+5WdnLd+7PDUrSJcZJ-caXGM8JmYU6YWHw@mail.gmail.com>
In-Reply-To: <1368260548-52612-3-git-send-email-davvid@gmail.com>

On Sat, May 11, 2013 at 4:22 AM, David Aguilar <davvid@gmail.com> wrote:

Show 14 quoted lines

> Mac OS X Mountain Lion prints warnings when building git:
>
>         warning: 'SHA1_Init' is deprecated
>         (declared at /usr/include/openssl/sha.h:121)
>
> Silence the warnings by using the Common Digest SHA-1
> functions for SHA1_Init(), SHA1_Update(), and SHA1_Final().
>
> Add a COMMON_DIGEST_SHA1 knob to the Makefile to allow
> choosing this implementation and define it by default on Darwin.
>
> Signed-off-by: David Aguilar <davvid@gmail.com>
> ---
> Unchanged since last time; rebased to 3/3.

Ignore my earlier response. I had not seen your revised patches. With this patch series, the SHA1_Foo() warnings are indeed resolved, however, there are still a bunch of remaining deprecation warnings regarding ERR_error_string, SSL_get_error, X509_get_ext_d2i, and so forth.