Re: [PATCH v2 3/3] cache.h: eliminate SHA-1 deprecation warnings on OS X 10.8

From: David Aguilar <davvid@gmail.com>
Date: May 12, 2013, 21:47 UTC
Message-ID: <CAJDDKr6hzJjd4E0oTubBNi6RZFriqHUGZp27MoW+WYyMPCObiQ@mail.gmail.com>
In-Reply-To: <7vk3n3vqku.fsf@alter.siamese.dyndns.org>

On Sun, May 12, 2013 at 2:25 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 21 quoted lines

> David Aguilar <davvid@gmail.com> writes:
>
>> Yup, warnings still remain, but only in imap-send.c.  All the SHA1
>> ones are gone.  Those were particularly bothersome since they affected
>> several files.
>>
>> I haven't dug to deeply into how to fix these.  In case anyone has any
>> pointers, the warnings look like this:
>>
>> imap-send.c: In function ‘ssl_socket_perror’:
>> imap-send.c:185: warning: ‘ERR_error_string’ is deprecated (declared
>> at /usr/include/openssl/err.h:279)
>
> Hmph.
>
> I thought your separate imap-send patch switched to CommonCrypto.
> Why are you still including from /usr/include/openssl/?
>
> By the way, is CommonCrypo anything "common"?  I am geting an
> impression that it is an Apple-only thing, and if that is the case
> the naming feels somewhat funny.

Far from common -- it's an Apple-ism.

The imap-send patch switches the HMAC parts to CommonCrypto and do eliminate the HMAC warnings. It still includes the x509 headers from SSL. I haven't figured those out. -- David