git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/3] Makefile: fix default regex settings on Darwin

From
David Aguilar <davvid@gmail.com>
Date
May 11, 2013, 08:22 UTC
Message-ID
<1368260548-52612-1-git-send-email-davvid@gmail.com>
t0070-fundamental.sh fails on Mac OS X 10.8:
	$ uname -a
	Darwin lustrous 12.2.0 Darwin Kernel Version 12.2.0:
	Sat Aug 25 00:48:52 PDT 2012;
	root:xnu-2050.18.24~1/RELEASE_X86_64 x86_64
	$ ./t0070-fundamental.sh -v
	fatal: regex bug confirmed: re-build git with NO_REGEX=1
Fix it by using Git's regex library.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: David Aguilar <davvid@gmail.com>
---
Added uname output and Jonathan's review tag.
 Makefile | 1 +
 1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index 0f931a2..f698c1a 100644
--- a/Makefile
+++ b/Makefile
@@ -1054,6 +1054,7 @@ ifeq ($(uname_S),Darwin)
 			BASIC_LDFLAGS += -L/opt/local/lib
 		endif
 	endif
+	NO_REGEX = YesPlease
 	PTHREAD_LIBS =
 endif
 
-- 
1.8.3.rc1.47.g41936fa
Next: David Aguilar
Message 1 of 8 in “Makefile: fix default regex settings on Darwin”
  1. 1/3 Makefile: fix default regex settings on DarwinDavid Aguilar, May 11, 2013
  2. 2/3 imap-send: eliminate HMAC warnings on OS X 10.8David Aguilar, May 11, 2013
  3. 3/3 cache.h: eliminate SHA-1 deprecation warnings on OS X 10.8David Aguilar, May 11, 2013
  4. Eric SunshineMay 12, 2013
  5. David AguilarMay 12, 2013
  6. Junio C HamanoMay 12, 2013
  7. David AguilarMay 12, 2013
  8. Eric SunshineMay 13, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.