Re: [PATCH 19/21] builtin/config: track "fixed value" option via flags only

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 11, 2024, 16:52 UTC
Message-ID: <CAPig+cSf1BcAYKk4Mg4Nn8TV6L_VRQg0tXvUcNykFcnwdiFf3w@mail.gmail.com>
In-Reply-To: <625216a7741b64b63717c72fd3c906b04c256bbf.1715339393.git.ps@pks.im>

On Sat, May 11, 2024 at 8:11 AM Patrick Steinhardt <ps@pks.im> wrote:

Show 7 quoted lines

> We track the "fixed value" option via two separate bits: once via the
> global variable `fixed_value`, and once via the CONFIG_FLAGS_FIXED_VALUE
> bit in `flags`. This is confusing and may easily lead to issues when one
> is not aware that this is tracked via two separate mechanisms.
>
> Refactor the code to use the flag exclusively. We already pass it to all
> the require callsites anyway, except for `collect_config()`.

s/require/required/

> Signed-off-by: Patrick Steinhardt <ps@pks.im>

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.