From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sat, 11 May 2024 16:52:05 GMT
Subject: Re: [PATCH 19/21] builtin/config: track "fixed value" option via flags only
Message-ID: <CAPig+cSf1BcAYKk4Mg4Nn8TV6L_VRQg0tXvUcNykFcnwdiFf3w@mail.gmail.com>
In-Reply-To: <625216a7741b64b63717c72fd3c906b04c256bbf.1715339393.git.ps@pks.im>

On Sat, May 11, 2024 at 8:11 AM Patrick Steinhardt <ps@pks.im> wrote:
> We track the "fixed value" option via two separate bits: once via the
> global variable `fixed_value`, and once via the CONFIG_FLAGS_FIXED_VALUE
> bit in `flags`. This is confusing and may easily lead to issues when one
> is not aware that this is tracked via two separate mechanisms.
>
> Refactor the code to use the flag exclusively. We already pass it to all
> the require callsites anyway, except for `collect_config()`.

s/require/required/

> Signed-off-by: Patrick Steinhardt <ps@pks.im>