Re: [PATCH v2 00/21] builtin/config: remove global state

From: Junio C Hamano <gitster@pobox.com>
Date: May 14, 2024, 14:48 UTC
Message-ID: <xmqqzfss78kw.fsf@gitster.g>
In-Reply-To: <cover.1715595550.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 10 quoted lines

> this is the second version of my patch series that removes global state
> from "builtin/config.c". Changes compared to v1:
>
>   - Reinstated a comment in patch 5.
>
>   - Fixed a memory leak in patch 9.
>
>   - A couple of commit message fixes.
>
> The series continues to build on top of ps/config-subcommands.

I do not offhand know if this iteration has already been seen by me, but a few recent CI runs of 'seen' did break with *-leaks jobs in t13XX series around "config". Hopefully with the fix in "patch 9" listed above the problem has gone away? We'll know soon enough when I push out the integration result.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.