Re: [PATCH 04/11] t7001: change the style for cd according to subshell

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sep 25, 2020, 18:12 UTC
Message-ID: <CAPig+cSb2nB0cK-3Xh=5mhTa6Knh0in-wFE-DQ7MiKGWv=qR=g@mail.gmail.com>
In-Reply-To: <20200925170256.11490-5-shubhunic@gmail.com>

On Fri, Sep 25, 2020 at 1:03 PM shubham verma <shubhunic@gmail.com> wrote:

> t7001: change the style for cd according to subshell
>
> In some tests there is not a proper spaces after opening paranthesis
> and before cd. So, Lets change the style for cd according to subshell.

Nits: s/space/newline/ s/paranthesis/parenthesis/ s/So, Lets change/Change/

However, a more significant observation is that this change is actually specific to the formatting of subshells, and has nothing to do with placement of `cd`, so calling out `cd` in the commit message is misleading. I'd probably drop mention of `cd` altogether and write the commit message something like this:

    t7001: modernize subshell formatting

    Some test use an old style for formatting subshells:

        (command &&
            ...

    Update them to the modern style:

        (
            command &&
            ...

The actual patch is fine.

> Signed-off-by: shubham verma <shubhunic@gmail.com>