Re: [PATCH 01/11] t7001: convert tests from the old style to the current style

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sep 25, 2020, 17:40 UTC
Message-ID: <CAPig+cQz5GjWH8PXkTsZ_cygmjjaxLBhRrZd_k2k23-aznRxhg@mail.gmail.com>
In-Reply-To: <20200925170256.11490-2-shubhunic@gmail.com>

On Fri, Sep 25, 2020 at 1:03 PM shubham verma <shubhunic@gmail.com> wrote:

> t7001: convert tests from the old style to the current style
>
> To modernize the t7001 test script, let's change the style of
> its tests from an old one to the modern one.

This commit message could help reviewers more by giving an example of how the style is being updated because it's not so easy to pick up the details from the patch itself since it's so noisy. Perhaps the commit message could say something like:

    t7001: modernize test formatting

    Some tests in this script are formatted using a very old style:

        test_expect_success \
            'title' \
            'body line 1 &&
            body line 2'

    Update the formatting to the modern style:

        test_expect_success 'title' '
            body line 1 &&
            body line 2
        '

> Signed-off-by: shubham verma <shubhunic@gmail.com>