Re: [PATCH 03/11] t7001: remove unnecessary blank lines

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sep 25, 2020, 17:50 UTC
Message-ID: <CAPig+cQWvn0YXUZRHE2ocH8+FS1aAnhjKiMsQvXXkNQ7LgEmfg@mail.gmail.com>
In-Reply-To: <20200925170256.11490-4-shubhunic@gmail.com>

On Fri, Sep 25, 2020 at 1:03 PM shubham verma <shubhunic@gmail.com> wrote:

> Some tests use a deprecated style in which there are unnecessary
> blank lines after the opening quote of the test body and before the
> closing quote. So we should removed these unnecessary blank lines.

s/So we should removed/Remove/

Otherwise, nice explanatory commit message.

One comment below not related directly to this patch (just something noticed in the patch conext lines)...

Show 10 quoted lines

> Signed-off-by: shubham verma <shubhunic@gmail.com>
> ---
> diff --git a/t/t7001-mv.sh b/t/t7001-mv.sh
> @@ -182,7 +182,6 @@ test_expect_success "Sergey Vlasov's test case" '
>  test_expect_success 'absolute pathname' '(
>      ...
>  )'
>  test_expect_success 'absolute pathname outside should fail' '(
>      ...
>  )'

It is very uncommon style to hide the subshell as these two tests do:

    test_expect_success 'title' '(
        ...
    )'

Instead, these should be formatted as:

    test_expect_success 'title' '
        (
            ...
        )
    '

Note that the "(" and ")" of the subshell are indented with a TAB, and then the body of the subshell is indented again with another TAB in order to comply with current style guidelines.

Fixing these might possibly be done in patch [1/11], however, they are so unusual and would change indentation of the body lines that they might deserve a patch of their own to avoid being lost in the noise of [1/11].