Re: [PATCH v3] bisect: report the found commit with "show"
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Apr 15, 2024, 21:33 UTC
- Message-ID
- <CAPig+cSY3vp6V=4SWmxyCi+7QY74eGnzPM6bu5LU5j00n8-j5g@mail.gmail.com>
- In-Reply-To
- <xmqq7cgyl3pr.fsf@gitster.g>
On Mon, Apr 15, 2024 at 5:24 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 11 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes: > >> Pass some hard-coded options to "git show" to make the output similar > >> to the one we are replacing, such as showing a patch summary only. > >> > >> Signed-off-By: Peter Krefting <peter@softwolves.pp.se> > >> --- > > Curious how you trimmed the trailers from the submitted patch ;-) > > Although we do not use Cc: in this project, we do recommend use of > the "Reported-by" trailer in Documentation/SubmittingPatches.
Sorry if that caused any confusion. I wasn't trying to make some sort of implicit suggestion to the patch author (such as "don't use Cc: trailers"). Rather, to ease the reading burden for others, I habitually trim off chunks of the email which aren't relevant to the portions about which I'm commenting. So, although I always leave the Signed-off-by: intact, I often trim off other trailers, sometimes even parts of the commit message (replacing with "[...]"), and, of course, entire chunks of the patch body.