Re: [PATCH v3] bisect: report the found commit with "show"

From: Peter Krefting <peter@softwolves.pp.se>
Date: Apr 16, 2024, 19:44 UTC
Message-ID: <70e5d02e-7728-260b-40c3-a19cf68d9b0e@softwolves.pp.se>
In-Reply-To: <20240416051358.GB1745631@coredump.intra.peff.net>

Eric sunshine:

> Style nit: On this project, multi-line comments are formatted like this:

Indeed. Fixed this in v4.

Junio C Hamano:

>>> Signed-off-By: Peter Krefting <peter@softwolves.pp.se>
>>> ---
> Curious how you trimmed the trailers from the submitted patch ;-)

Yeah. I had some extra information in my local commit footer, to make sure I remember add the correct Cc in the outgoing mail. I didn't intend to remove the Reported-by trailer (and in v4 I see that I forgot to trim it at all; so much for posting stuff late in the evening, especially just after pushing a localization update).

Show 6 quoted lines

> What is more problematic is that the message is sent with
>
> 	Content-Type: text/plain; format=flowed; charset=US-ASCII
>
> and the contents of the message is in that flawed format, possibly 
> corrupting whitespaces in irrecoverable ways.

Right. I need to remember to disable that when posting patches. I haven't come around to trying to get the Git built-in tools for sending patches, as the last patch I submitted this way was in 2009, two mail hosts ago. It oughtn't have been corrupted by that as it was just an import of the git format-patch output file, and...

> Peter, if the resulting commit I push out later today botches some 
> whitespaces due to this issue, please complain.

...it comes out just fine (as a v3.5 patch, as my v4 also changed the command-line options, which we should not).

Eric Sunshine:

> Sorry if that caused any confusion. I wasn't trying to make some 
> sort of implicit suggestion to the patch author (such as "don't use 
> Cc: trailers").

It was not you, it was me trimming the posted patch a little bit too much.

-- 
\\// Peter - http://www.softwolves.pp.se/