Re: [PATCH v3] bisect: report the found commit with "show"
- From
Jeff King <peff@peff.net>
- Date
- Apr 16, 2024, 05:13 UTC
- Message-ID
- <20240416051358.GB1745631@coredump.intra.peff.net>
- In-Reply-To
- <CAPig+cSY3vp6V=4SWmxyCi+7QY74eGnzPM6bu5LU5j00n8-j5g@mail.gmail.com>
On Mon, Apr 15, 2024 at 05:33:29PM -0400, Eric Sunshine wrote:
Show 13 quoted lines
> > Curious how you trimmed the trailers from the submitted patch ;-) > > > > Although we do not use Cc: in this project, we do recommend use of > > the "Reported-by" trailer in Documentation/SubmittingPatches. > > Sorry if that caused any confusion. I wasn't trying to make some sort > of implicit suggestion to the patch author (such as "don't use Cc: > trailers"). Rather, to ease the reading burden for others, I > habitually trim off chunks of the email which aren't relevant to the > portions about which I'm commenting. So, although I always leave the > Signed-off-by: intact, I often trim off other trailers, sometimes even > parts of the commit message (replacing with "[...]"), and, of course, > entire chunks of the patch body.
FWIW, as a reader I very much appreciate when people trim their quotes to the most relevant bits.
-Peff