Re: [PATCH 1/2] git-gui: warn if the commit message contains lines longer than the set limit

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sep 4, 2019, 20:29 UTC
Message-ID: <CAPig+cSL0fpc5cVgO1soAksD2b5xadkDLG+JxiDCi5s95VRU_A@mail.gmail.com>
In-Reply-To: <7da71d89f9fa987eca2e25974e4cec382c146e44.1567627609.git.bert.wesarg@googlemail.com>

On Wed, Sep 4, 2019 at 4:10 PM Bert Wesarg <bert.wesarg@googlemail.com> wrote:

> The commit message widget does not wrap the next and has a configurable

s/next/text/

> fixed width to avoid creating too wide commit messages. Though this was
> only enforced in the GUI. Now we also check the commit message at commit
> time for long lines and ask the author for confirmation if it exceeds the
> configured line length.

Hmm, more confirmation dialogs tend to mean more annoyance for users, especially considering that the line length limit is a project-specific _policy_ (so this has the potential to annoy a lot of people), and also because there often are legitimate reasons for exceeding the limit (such as pasting in URLs).

As an alternative to a confirmation dialog, how about instead adding a _warning_ message (perhaps with red text) on the window itself alongside to the commit message field (below or above it or something)? Is that something that could be triggered by a text widget callback?

Show 5 quoted lines

> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
> ---
> diff --git a/lib/commit.tcl b/lib/commit.tcl
> @@ -215,6 +215,16 @@ A good commit message has the following format:
> +       if {[tcl::mathfunc::max {*}[lmap x [split $msg "\n"] {string length $x}]] >= $repo_config(gui.commitmsgwidth) \

Does this take TABs into account?