git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] git-gui: warn if the commit message contains lines longer than the set limit

From
Pratyush Yadav <me@yadavpratyush.com>
Date
Sep 10, 2019, 20:34 UTC
Message-ID
<20190910203456.te2onnr3eibw2pjn@yadavpratyush.com>
In-Reply-To
<7da71d89f9fa987eca2e25974e4cec382c146e44.1567627609.git.bert.wesarg@googlemail.com>
On 04/09/19 10:10PM, Bert Wesarg wrote:
Show 5 quoted lines
> The commit message widget does not wrap the next and has a configurable
> fixed width to avoid creating too wide commit messages. Though this was
> only enforced in the GUI. Now we also check the commit message at commit
> time for long lines and ask the author for confirmation if it exceeds the
> configured line length.

Thanks for the patch, but I'm not a big fan of this. I agree with Eric that more dialogs are annoying. Even as a temporary change until we have word wrap support, I don't like it. I hope you don't mind if I only take the scrollbar change and drop this.

-- 
Regards,
Pratyush Yadav
Previous: Bert WesargNext: Bert Wesarg
Message 20 of 21 in “git-gui: warn if the commit message contains lines longer than the set limit”
  1. 1/2 git-gui: warn if the commit message contains lines longer than the set limitBert Wesarg, Sep 4, 2019
  2. 2/2 git-gui: add horizontal scrollbar to commit bufferBert Wesarg, Sep 4, 2019
  3. Eric SunshineSep 4, 2019
  4. Bert WesargSep 4, 2019
  5. Pratyush YadavSep 10, 2019
  6. Bert WesargSep 12, 2019
  7. Eric SunshineSep 4, 2019
  8. Bert WesargSep 4, 2019
  9. Pratyush YadavSep 4, 2019
  10. Birger Skogeng PedersenSep 5, 2019
  11. Bert WesargSep 5, 2019
  12. Birger Skogeng PedersenSep 6, 2019
  13. Philip OakleySep 6, 2019
  14. David AguilarSep 10, 2019
  15. Pratyush YadavSep 10, 2019
  16. Johannes SixtSep 5, 2019
  17. Bert WesargSep 5, 2019
  18. Johannes SixtSep 10, 2019
  19. Bert WesargSep 12, 2019
  20. Pratyush YadavSep 10, 2019
  21. Bert WesargSep 12, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.