[PATCH 2/2] git-gui: add horizontal scrollbar to commit buffer
- From
Bert Wesarg <bert.wesarg@googlemail.com>
- Date
- Sep 4, 2019, 20:10 UTC
- Message-ID
- <62ef03a2938ac0d2158b1c3201c7f10e52e30ecb.1567627609.git.bert.wesarg@googlemail.com>
- In-Reply-To
- <7da71d89f9fa987eca2e25974e4cec382c146e44.1567627609.git.bert.wesarg@googlemail.com>
While the commit message widget has a configurable fixed width, it nevertheless allows to write commit messages which exceed this limit. Though it does not show this content because there is not scrollbar for this widget. No it is.
There seems to be a bug in at least up to Tcl/Tk 8.6.8, which does not update the horizontal scrollbar if one removes the whole content at once.
Suggested-by: Birger Skogeng Pedersen <birger.sp@gmail.com> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com> --- git-gui.sh | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh index a491085..fa9c0d2 100755 --- a/git-gui.sh +++ b/git-gui.sh @@ -3363,14 +3363,20 @@ ttext $ui_comm -background white -foreground black \ -relief sunken \ -width $repo_config(gui.commitmsgwidth) -height 9 -wrap none \ -font font_diff \ + -xscrollcommand {.vpane.lower.commarea.buffer.frame.sbx set} \ -yscrollcommand {.vpane.lower.commarea.buffer.frame.sby set} +${NS}::scrollbar .vpane.lower.commarea.buffer.frame.sbx \ + -orient horizontal \ + -command [list $ui_comm xview] ${NS}::scrollbar .vpane.lower.commarea.buffer.frame.sby \ + -orient vertical \ -command [list $ui_comm yview] +pack .vpane.lower.commarea.buffer.frame.sbx -side bottom -fill x pack .vpane.lower.commarea.buffer.frame.sby -side right -fill y -pack $ui_comm -side left -fill y +pack $ui_comm -side left -fill both -expand 1 pack .vpane.lower.commarea.buffer.header -side top -fill x -pack .vpane.lower.commarea.buffer.frame -side left -fill y +pack .vpane.lower.commarea.buffer.frame -side bottom -fill both -expand 1 pack .vpane.lower.commarea.buffer -side left -fill y # -- Commit Message Buffer Context Menu
-- 2.21.0.789.ga095d9d866