git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/7] Modernize t9300-fast-import

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Nov 20, 2015, 03:54 UTC
Message-ID
<CAPig+cSH+BnvnzVY=YhRknynyWkAdbXNMvvrb7GcjEnf6UDFug@mail.gmail.com>
In-Reply-To
<cover.1447959452.git.j6t@kdbg.org>
On Thu, Nov 19, 2015 at 2:09 PM, Johannes Sixt <j6t@kdbg.org> wrote:
Show 7 quoted lines
> Some time ago, I had to dig into t9300-fast-import and found it quite
> unhelpful that it does not follow our modern best-practices. This series
> brings it up-to-date. I thought I submit it now while it is quiet in
> the area.
>
> The larger patches are best viewed using -w -color-words because the
> regular patch text is ... overwhelming.

For what it's worth, I read through the series (with care, I hope) and didn't find anything amiss.

> Improving shell coding style is outside the scope of this series. I mean
> fixing eyesores such as 'cat >foo <<EOF && cat foo | sort > bar', or minor
> things such as quoting <<\EOF when the here-doc does not require
> substitutions.
Previous: Johannes SixtNext: Jeff King
Message 9 of 10 in “Modernize t9300-fast-import”
  1. 0/7 Modernize t9300-fast-importJohannes Sixt, Nov 19, 2015
  2. 1/7 modernize t9300: single-quote placement and indentationJohannes Sixt, Nov 19, 2015
  3. 2/7 modernize t9300: use test_must_failJohannes Sixt, Nov 19, 2015
  4. 3/7 modernize t9300: use test_must_be_emptyJohannes Sixt, Nov 19, 2015
  5. 4/7 modernize t9300: wrap lines after &&Johannes Sixt, Nov 19, 2015
  6. 5/7 modernize t9300: use test_when_finished for clean-upJohannes Sixt, Nov 19, 2015
  7. 6/7 modernize t9300: mark here-doc words to ignore tab indentationJohannes Sixt, Nov 19, 2015
  8. 7/7 modernize t9300: move test preparations into test_expect_successJohannes Sixt, Nov 19, 2015
  9. Eric SunshineNov 20, 2015
  10. Jeff KingNov 20, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.