From: Eric Sunshine <sunshine@sunshineco.com>
Date: Fri, 20 Nov 2015 03:54:11 GMT
Subject: Re: [PATCH 0/7] Modernize t9300-fast-import
Message-ID: <CAPig+cSH+BnvnzVY=YhRknynyWkAdbXNMvvrb7GcjEnf6UDFug@mail.gmail.com>
In-Reply-To: <cover.1447959452.git.j6t@kdbg.org>

On Thu, Nov 19, 2015 at 2:09 PM, Johannes Sixt <j6t@kdbg.org> wrote:
> Some time ago, I had to dig into t9300-fast-import and found it quite
> unhelpful that it does not follow our modern best-practices. This series
> brings it up-to-date. I thought I submit it now while it is quiet in
> the area.
>
> The larger patches are best viewed using -w -color-words because the
> regular patch text is ... overwhelming.

For what it's worth, I read through the series (with care, I hope) and
didn't find anything amiss.

> Improving shell coding style is outside the scope of this series. I mean
> fixing eyesores such as 'cat >foo <<EOF && cat foo | sort > bar', or minor
> things such as quoting <<\EOF when the here-doc does not require
> substitutions.