git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/7] modernize t9300: use test_must_fail

From
Johannes Sixt <j6t@kdbg.org>
Date
Nov 19, 2015, 19:09 UTC
Message-ID
<46b654a91df9ae0c85e406e6a17ca918b63351ee.1447959452.git.j6t@kdbg.org>
In-Reply-To
<cover.1447959452.git.j6t@kdbg.org>

One test case open-codes a test for an expected failure. Replace it by test_must_fail.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 t/t9300-fast-import.sh | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)
diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh
index 566f7bd..e9c7602 100755
--- a/t/t9300-fast-import.sh
+++ b/t/t9300-fast-import.sh
@@ -630,20 +630,9 @@ from refs/heads/branch
 
 INPUT_END
 test_expect_success 'F: non-fast-forward update skips' '
-	if git fast-import <input
-	then
-		echo BAD gfi did not fail
-		return 1
-	else
-		if test $old_branch = `git rev-parse --verify branch^0`
-		then
-			: branch unaffected and failure returned
-			return 0
-		else
-			echo BAD gfi changed branch $old_branch
-			return 1
-		fi
-	fi
+	test_must_fail git fast-import <input &&
+	# branch must remain unaffected
+	test $old_branch = `git rev-parse --verify branch^0`
 '
 
 test_expect_success 'F: verify pack' '
-- 
2.6.2.337.ga235d84
Previous: Johannes SixtNext: Johannes Sixt
Message 3 of 10 in “Modernize t9300-fast-import”
  1. 0/7 Modernize t9300-fast-importJohannes Sixt, Nov 19, 2015
  2. 1/7 modernize t9300: single-quote placement and indentationJohannes Sixt, Nov 19, 2015
  3. 2/7 modernize t9300: use test_must_failJohannes Sixt, Nov 19, 2015
  4. 3/7 modernize t9300: use test_must_be_emptyJohannes Sixt, Nov 19, 2015
  5. 4/7 modernize t9300: wrap lines after &&Johannes Sixt, Nov 19, 2015
  6. 5/7 modernize t9300: use test_when_finished for clean-upJohannes Sixt, Nov 19, 2015
  7. 6/7 modernize t9300: mark here-doc words to ignore tab indentationJohannes Sixt, Nov 19, 2015
  8. 7/7 modernize t9300: move test preparations into test_expect_successJohannes Sixt, Nov 19, 2015
  9. Eric SunshineNov 20, 2015
  10. Jeff KingNov 20, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.